BalintCsala / VulkaniteDemoPack

Vulkanite Demo Pack
MIT License
10 stars 1 forks source link

Rendering is messed up? #6

Closed Fusion-Flux closed 1 year ago

Fusion-Flux commented 1 year ago

its kinda hard to explain so ill just send images image

basically everything ends up super dark and just unviewable ocasionally it is viewable but looks like this

image

Fusion-Flux commented 1 year ago

running on a RTX 3060 doesnt really matter if its on linux or windows ive tested on both it seems to cycle between these viewings its strange

image

DarianLStephens commented 1 year ago

You require a PBR resource pack for this to work. Unfortunately, this is not mentioned anywhere, merely stated as 'having PBR compatibility'. I've been using VanillaPBR, and it works pretty well.

Note that the mod and shader are definitely not ready for general use. A huge problem is that denoising only seems to exist for sunlight rays, meaning all other light sources will be the raw ray information, appearing as many many incomprehensible dots.

BalintCsala commented 1 year ago

@Fusion-Flux As Darian mentioned, this pack needs a resourcpeack, doesn't work without one. This might be adressed in the future, but as long as it's in the tech demo phase don't expect it (not that it would look great either way).

A huge problem is that denoising only seems to exist for sunlight rays, meaning all other light sources will be the raw ray information, appearing as many many incomprehensible dots.

@DarianLStephens no, everything is denoised

DarianLStephens commented 1 year ago

A huge problem is that denoising only seems to exist for sunlight rays, meaning all other light sources will be the raw ray information, appearing as many many incomprehensible dots.

@DarianLStephens no, everything is denoised

Wait, huh? I could definitely be wrong, but this doesn't look denoised: 2023-10-06_13 11 01

Sunlight, however, looks fine (With the exception of bounced light): 2023-10-06_13 10 15

Is there a problem with my game, then, or is this how it's expected to work at the moment? Or maybe my terminology is wrong, and the whole 'turning rays in to a coherent image' thing isn't what denoising is about?

BalintCsala commented 1 year ago

@DarianLStephens Try to load in a dark scene with something other than just a single tiny torch illuminating it, the denoiser is there, it's just not a good one. Alternatively turn reprojection frames down to 1 and see how it affects both scenes.

DarianLStephens commented 1 year ago

Looks slightly better, I guess, but still not good. 2023-10-07_12 49 14 With only a single block of glowstone, it's comparable to the torch: 2023-10-07_12 49 47

There's also no 'reprojection frames' option I can see. Is that something in development? I've just got the mod and shader off Modrinth. 2023-10-07_12 49 58

BalintCsala commented 1 year ago

@DarianLStephens meant reprojection length

DarianLStephens commented 1 year ago

Ah. Well, I tried turning down the 'Accumulation length', but that seemed to make the whole image more unstable, and killed lights for the most part.

BalintCsala commented 1 year ago

@DarianLStephens Yes, that's the effect of the very weak denoiser in there right now, it just has a better time with direct lighting because rays are simply more likely to hit the sun

DarianLStephens commented 1 year ago

I see, I see. Well, I look forward to seeing future developments in the shader and Vulkanite as a whole. I saw some merges being done, quite exciting.

When the whole system is in a playable state, I will likely never touch Bedrock again. RTX is the only reason I even consider playing it sometimes, and even then I always run it on a Java server with Geyser and some server-side mods.

Fusion-Flux commented 1 year ago

Sorry forgot about this post completely. using pbr i still experience simular issues though rarely i can boot and it just works image

Fusion-Flux commented 1 year ago

had to use infinite accumulation to get the right effect but you get it it mostly works

Fusion-Flux commented 1 year ago

The usual effect i consistantly get is just everything being strangely dark image