search

BallAerospace / COSMOS

Ball Aerospace COSMOS
https://ballaerospace.github.io/cosmos-website/
Other
360 stars 129 forks source link

set needs_dependencies if there is a top level lib folder #1703

Closed ghost closed 2 years ago

ghost commented 2 years ago

We need to mount in the /gems folder if a plugin has a top-level lib folder so that its lib files are available.

Note: Top-Level lib must not include ERB so that it will work as a regular gem. These files are not ever ERB parsed or copied to minio. They are only available in the installed gem.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1703 (ae33a48) into master (50f291e) will increase coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
+ Coverage   78.23%   78.25%   +0.02%     
==========================================
  Files         235      235              
  Lines       18140    18147       +7     
==========================================
+ Hits        14191    14201      +10     
+ Misses       3949     3946       -3
Impacted Files Coverage Δ
lib/cosmos/models/plugin_model.rb 95.41% <0.00%> (+3.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50f291e...ae33a48. Read the comment docs.

ghost commented 2 years ago

needs_dependencies is used in microservice_operator.rb