search

BallAerospace / python-ballcosmos

Python Support for Ball Aerospace COSMOS v4
Other
18 stars 4 forks source link

Formatting and Spaces Fix #7

Closed dmitri-mcguckin closed 3 years ago

dmitri-mcguckin commented 4 years ago

I'm interested in contributing some code very soon since this module is important for work I do for the OreSat Project.

However, I noticed most of the source files had an uneven amount of spaces for tabbing. Python being the way it is, this meant I was unable to run any of the source files locally. Ergo I can't make my contributions yet.

So with vim and a bit of scripting, I went through and fixed the tabbing issue, as well as some other minor style issues like the E302 standard according to the official python style guide.

I haven't changed much of the source code itself yet, so as far as I've tested, the module is still in working order.

Do let me know your thoughts.

All the best.

ghost commented 3 years ago

Thank you for the pull request. However, this does not meet the COSMOS coding standards.
We use 2 space indent not 4, also you have changed several files to executable that don't need to be.