BallStateCBER / commentaries-cake3

CBER Data Center: Weekly Commentary
0 stars 0 forks source link

Restore style rules from CakePHP 2 version of site #10

Closed PhantomWatson closed 6 years ago

PhantomWatson commented 6 years ago

Things that have lost their styling:

(I may have more notes for the admin parts of the site, but I can't currently access them, as the credentials that I use to log in to the CakePHP 2 version of the site don't work for this version)

ericadestoya commented 6 years ago

the credentials that I use to log in to the CakePHP 2 version of the site don't work for this version

oh no. they should... I just went through this making sure they had the same salts and a working rehasher and everything. It was tested for this, argh...

ericadestoya commented 6 years ago

Actually, would you mind attaching a screencap on here of what the front page of the site looks like on your end?

PhantomWatson commented 6 years ago

c04ad042-7510-4f02-b511-50ee2c30b166

ericadestoya commented 6 years ago

aww damn that's what I thought... yeah, here's mine:

image

I got all the styling errors you're seeing on your end, when I fiddled with the Datacenter plugin so that it'd look for datacenter.css rather than style.css.

PhantomWatson commented 6 years ago

datacenter.less is only @imported when each site's style.less is compiled into style.css and not compiled/loaded directly, so there shouldn't be any datacenter.css for the plugin to look for.

ericadestoya commented 6 years ago

I meant datacenter.cake2.css, my mistake

ericadestoya commented 6 years ago

dropdownyear

How's this for a solution to the Too Many Years problem?

PhantomWatson commented 6 years ago

Very good! The only improvement that I can think of is making "Select a year" the <label> for that <select>. Maybe with the arrow character changed to <span class="glyphicon glyphicon-arrow-right"> or just a colon.

ericadestoya commented 6 years ago

cloudvslist

[shrug] Togglers always get me. Lemme see if I can find a toggler that's an actual switch that one could slide or something to that effect.

ericadestoya commented 6 years ago

toggle buttonz

A little more in-your-face I suppose...

ericadestoya commented 6 years ago

The only improvement that I can think of is making "Select a year" the <label> for that <select>.

Right, or else screen readers will get confused and their users will get irritated

PhantomWatson commented 6 years ago

Looks good. I suggest giving one of them an "active" style so show which is currently selected.

Also, there's a logarithmic tag-cloud-sizing formula that I rigged up for Muncie Events that I should get around to applying to this site, too. It reduced the huge difference between the sizes of the most-used and least-used tags.

ericadestoya commented 6 years ago

^^I can do that right quick. It's just some different math.

PhantomWatson commented 6 years ago

Here's how I did it for Muncie Events: https://github.com/BallStateCBER/muncie_events/blob/development/app/View/Tags/index.ctp#L143

ericadestoya commented 6 years ago

yes

here we are