search

BallStateCBER / cri

CBER Data Center: Community Readiness Initiative
http://cri.cberdata.org
0 stars 0 forks source link

Use class constants for valid Respondents.approved values #80

Open PhantomWatson opened 4 years ago

PhantomWatson commented 4 years ago

The -1, 0, and 1 values for 'Respondents.approved' should really be changed to class constants. Suggestions:

-1 => RespondentsTable::DISMISSED
 0 => RespondentsTable::NOT_ADDRESSED
 1 => RespondentsTable::APPROVED

And these integers should be changed to references to those class constants in all of the appropriate getters and setters.