search

Ballasi / num2words

Convert numbers like 42 to forty-two
https://crates.io/crates/num2words
Apache License 2.0
17 stars 9 forks source link

Ukrainian language support #19

Closed pavloslav closed 11 months ago

pavloslav commented 11 months ago

Completed all functions for Ukrainian (currency fractions are still a bit of mess, but it looks like there are like that in the original too)

Ballasi commented 11 months ago

Hey, I've seen you do a lot of work in here, thanks a lot!

Sorry for the delay -- I was a bit inactive the last few days. I will take a look and answer everything you've been sending tomorrow. Once again, sorry if I wasn't active before, but I will answer everything! Thanks again.

pavloslav commented 11 months ago

It's ok, take your time. Just merge it so we can move on.

Ballasi commented 11 months ago

Hey, sorry for the extended delay, I did an initial review on your commits, can you take a look at them?

Thanks a lot for the contribution, it means a lot :)

pavloslav commented 11 months ago

Ok, I've closed the most issues. Still, several rustfmt::skip remain; and one more thing: I've added prefer() arguments description, but I think formatting is poor, and probably it should be split moved to specific languages. Any ideas?

Ballasi commented 11 months ago

Thank you for your hard work, it's very much appreciated!

I can be a little bit picky on my code review, it's just that I want it to be perfect, but your work is very well done, thank you again!

Ballasi commented 11 months ago

Hey, one small thing: there also needs to be two lines added in README.md and src/lib.rs in the Supported languages section to add a note for Ukrainian!

pavloslav commented 11 months ago

Added to Supported languages. Also rebased on current master, for cleaner merge.

pavloslav commented 11 months ago

Pavlo, you're working late once again...

pavloslav commented 11 months ago

Done

Ballasi commented 11 months ago

Thanks a lot Pavlo! that's very appreciated :)