Closed burlen closed 1 year ago
@rileyjmurray Could you take a look at this?
I'll look at this right away!
On Fri, Dec 9, 2022 at 12:41 PM Burlen Loring @.***> wrote:
@rileyjmurray https://github.com/rileyjmurray Could you take a look at this?
— Reply to this email directly, view it on GitHub https://github.com/BallisticLA/RandBLAS/issues/18#issuecomment-1344761264, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRLIFHGL2PNNPFOKIKEW4DWMOKQ3ANCNFSM6AAAAAASZXJTO4 . You are receiving this because you were mentioned.Message ID: @.***>
The problem is that vec_nnz = 8
and n_rows = 4
. We should raise an exception if vec_nnz > n_rows
. (In practice this should never happen, since n_rows
will be at least a few thousand and vec_nnz
should rarely be more than 8.)
Got it thanks! May be worth mentioning this in the rpc_svd_sjlt
Doxygen comments as well
user error
There's a floating point exception generated by the following line because
j == n_rows == 4
https://github.com/BallisticLA/RandBLAS/blob/550bbcd7962e9268012999ac6b67b221885721ee/include/RandBLAS/sjlts.hh#L89we got here by:
the value of sjl at this point is: