search

BallisticLA / RandBLAS

A header-only C++ library for sketching in randomized linear algebra
https://randblas.readthedocs.io/en/stable/
Other
75 stars 6 forks source link

integrate templated RNGState #28

Closed burlen closed 1 year ago

burlen commented 1 year ago

This contains everything on #25 including prototypes and improvements to the dense implementation as well as integration for sparse. On the sparse side I tried to make minimal changes.

burlen commented 1 year ago

@rileyjmurray thanks for the review. I see some improvements based on your input. I think can address your concerns. Will ping you when it's ready for another look.

burlen commented 1 year ago

@rileyjmurray I took a stab at addressing some of the issue you pointed out. Did I address your concerns? I'll hold off on merging this until I hear back from you.

rileyjmurray commented 1 year ago

@burlen I have no remaining questions. Please merge when you're ready!