search

BallisticLA / RandBLAS

A header-only C++ library for sketching in randomized linear algebra
https://randblas.readthedocs.io/en/latest/
Other
66 stars 4 forks source link

testing add address sanitizer runs #31

Closed burlen closed 1 year ago

burlen commented 1 year ago

this will catch memory leaks, invalid memory read/write, etc...

let's get #27 in before merging this

rileyjmurray commented 1 year ago

Ping @burlen: I resolved a merge conflict so that we could run CI. Not sure if I resolved in the appropriate way, but we're getting a CMake error with these changes.

rileyjmurray commented 1 year ago

I fixed a memory leak in test_sparse.cc identified by the address sanitizer. However, address sanitizer also identified nontrivial leaks in dense.hh. All failing test fixtures trace back to the sketch_eye() method of the TestLSKGE3 class.

burlen commented 1 year ago

@rileyjmurray leak fixed. macos failure is due to test tolerance not met