search

BallisticLA / RandBLAS

A header-only C++ library for sketching in randomized linear algebra
https://randblas.readthedocs.io/en/latest/
Other
66 stars 4 forks source link

GitHub Actions : test with openmp on macOS #48

Closed rileyjmurray closed 1 year ago

rileyjmurray commented 1 year ago

@burlen I noticed that blaspp found OpenMP for C++ in the latestopenmp-macos build, while RandBLAS only found OpenMP for C. It might be worth looking at how blaspp tries to configure OpenMP in their build process:

https://github.com/icl-utk-edu/blaspp/blob/master/CMakeLists.txt#LL312C1-L324C8.

From what I can tell, the only difference is that they use find_package( OpenMP ) instead of find_package( OpenMP COMPONENTS CXX).

burlen commented 1 year ago

@rileyjmurray the default compiler doesn't have OpenMP support, the trick was to point to the right compiler. Should we integrate the changes in to core-macos workflow?

burlen commented 1 year ago

@rileyjmurray all good (assuming I didn't break in latest)