search

BallisticLA / RandLAPACK

A high-performance C++ library for randomized numerical linear algebra
60 stars 6 forks source link

Revise QB tests and add dedicated tests for rangefinders #41

Closed rileyjmurray closed 1 year ago

rileyjmurray commented 1 year ago

We have dedicated tests for QB but no dedicated tests for rangefinders. We should add dedicated tests for rangefinders so that it's easier to develop correct code for more complicated algorithms. (I'm running into this problem in PR #39.)

It should be easy to write good rangefinder tests given good tests for QB. The main difference between rangefinders we work with and QB decomposers is that rangefinders are only fixed-rank, while QB decomposers can be fixed-rank or fixed-accuracy.

That said --- the existing QB tests are hard to follow. I think they should be revised before we attempt to adapt QB tests to rangefinder tests. The main problem with QB tests is that they require a mat_type argument that determines the nature of the test matrix in cryptic ways. It is better for test code to separate the logic of generating test data from the logic of carrying out the test itself. This is what we did with with PARLA.

rileyjmurray commented 1 year ago

Resolved by PRs #43 and #44.