BalticAmadeus / ProBro

VSCode extension for Progress OpenEdge Database browsing
https://marketplace.visualstudio.com/items?itemName=BalticAmadeus.pro-bro&ssr=false#overview
Apache License 2.0
5 stars 3 forks source link

ProBro VsCode not getting tables due to startup.pf settings #574

Closed cverbiest closed 2 weeks ago

cverbiest commented 1 month ago

Issue : Not getting tables for database

To Reproduce

  1. Start with same steps as #573
  2. Click on LISA database
  3. Observe spinner on db name
  4. See error in Developer tools

Expected behavior

table info is collected and shown

Developer tools output

[Extension Host] GroupList 
[{…}]
console.ts:137 [Extension Host] useNew: false
console.ts:137 [Extension Host] execShell params :  
{connectionString: '-db /data/domain/develop/db/LISA   -H domain-develop-dbhost -S 4500 -ct 1', command: 'get_tables'}
console.ts:137 [Extension Host] eyJjb25uZWN0aW********************************************************************************************W1hbmQiOiJnZXRfdGFibGVzIn0=
console.ts:137 [Extension Host] getOeClient error :  Cannot read properties of undefined (reading 'write')

Desktop

cverbiest commented 1 month ago

additional info, our $DLC contains following startup.pf. maybe some parameters conflict with what probro expects.

I'll try commenting those out

-cpinternal UTF-8
-cpstream UTF-8
-cpcoll Basic
-cpcase Basic
-d dmy
-numsep 46
-numdec 44
-T /tmp
-Mm 10240
cverbiest commented 1 month ago

After removing -d, -numsec, -numdec, -T & -Mm and restarting I do get a list of tables. Not sure with of those parameters causes the problem.

I'll try to make .vscode-server/extensions/balticamadeus.pro-bro-1.7.0/resources/oe/scripts/oe.sh more explicit

PauliusKu commented 2 weeks ago

Merged