search

Balvald / ArtemisScannerTracker

An EDMC plugin that keeps track of the exobiology scanner of a CMDRs Artemis suit in ED:Odyssey
GNU General Public License v3.0
24 stars 4 forks source link

[Feature] Journalcrawler should track and update notsoldbiodata.json #28

Closed Balvald closed 1 year ago

Balvald commented 1 year ago

Is your feature request related to a problem? Please describe. From a Forum post: I am out in the black so is there not anyway for this to scan my journals for just unsold data so I can see what I currently have is worth? I have only been out for a week so there are less than 20 journals to deal with.

Describe the solution you'd like The journal crawler should not only update the soldbiodata.json but also the notsoldbiodata.json

Balvald commented 1 year ago

Done for today. Will check this one again tomorrow

Balvald commented 1 year ago

Trying to think of any pitfalls that this can run into.

Technically thers now a third way to create discrepancies which could be averted if the SellOrganics event would state system and body of the exobiology sold in the journals:

That is get the journal crawler to read through journals that end up with any set of notsoldbiodata.json. Skip over a journal that has a resurrect event then have a "SellOrganic" event later where the code identifies that the whole batch needs to be sold. -> is not a problem if we get a full track record of things from any point in the past to the present. -> For now I'll be deeming the keeping a complete track of journals that does not have random missing "holes" to be used with the journal crawler sufficient to not run into this.

Gotta add this one to #11 sometime

Fixable Pitfall: Though there is the off chance where we have two sets of journals with some overlap where notsoldbiodata gets something added in the first run, that shouldn't be there after the second set of journals are crawled. -> Analyse event happens in the first set of journals and corresponding sell event happens in the second set. -> needs another check where prexisting elements in the notsoldbiodata have moved to the soldbiodata side of things. in the journal crawler.

Balvald commented 1 year ago

Looking back at this I forgot to add the tracking for the unsold value and it took two more incremental updates of just minor fixes for me to finally finish this one properly.

Balvald commented 1 year ago

Next time I could go and read it properly the first time round.