Import immutable ByteString from protobuf

[GoogleCodeExporter]

I'd love it if protobuf's immutable ByteString could make it into Guava. This 
is a useful class, even for users who aren't using protobuf and it seems like a 
shame to pull in the rest when I'm already importing Guava.

Original issue reported on code.google.com by mmast...@gmail.com on 4 Feb 2013 at 4:57

[GoogleCodeExporter]

Agreed...this has been on our radar for quite some time.

Original comment by kak@google.com on 4 Feb 2013 at 5:07

• Changed state: Accepted
• Added labels: Package-Base, Type-Addition

[GoogleCodeExporter]

+1 from me, but my motivation is to use both Guava and Protobuf, and have them 
work better together.  e.g. Have ByteString implement ByteSource; return 
ByteString instead of defensive byte array copies in Guava, etc.

It seems to me that the biggest problem is organizational - i.e. in which 
project does ByteString live?  If in Guava, protobuf would have to depend on 
it.  If in a new "Guava core", Guava would have to maintain that separation.  
Merging Protobuf-java and Guava would be great, but is probably unacceptable.  
Having Guava depend on Protobuf (or Protobuf core, containing ByteString) would 
be 80% good, but wouldn't allow e.g. ByteString to extend ByteSource. etc etc

Any thoughts on the preferred option?

Original comment by jus...@fathomdb.com on 11 Jan 2014 at 2:44

[GoogleCodeExporter]

Original comment by kak@google.com on 12 Jan 2014 at 2:41

[GoogleCodeExporter]

I think ultimately ByteString should go into the JDK itself.

Original comment by andreas....@gmail.com on 1 Jun 2014 at 9:25

[GoogleCodeExporter]

This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:13

• Added labels: MigratedToGitHub

[GoogleCodeExporter]

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:18

• Changed state: Migrated

[GoogleCodeExporter]

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:08

• Added labels: Restrict-AddIssueComment-Commit