Balzanka / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

Consider running a TestSuite instead of individual tests #1360

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I thought that this might be faster. It looks like it's not. It's possible that 
the particular implementation I used is running some tests more than once 
(probably the suite-builder tests). Performance might improve with better 
filtering. Even if it does, I'm no longer optimistic about performance 
improvements. Plus, I'm seeing some failures and errors (presumably fixable, 
but why bother now?).

The patch and output I ended up with are attached. In short, I was using 
http://www.johanneslink.net/projects/cpsuite.jsp

Failed tests:
  testCleanupOnReferenceCollection(com.google.common.cache.CacheReferencesTest): expected:<1> but was:<2>
  warning(junit.framework.TestSuite$1): Class com.google.common.io.ByteSinkTester has no public constructor TestCase(String name) or TestCase()
  warning(junit.framework.TestSuite$1): Class com.google.common.io.ByteSourceTester has no public constructor TestCase(String name) or TestCase()
  warning(junit.framework.TestSuite$1): Class com.google.common.io.CharSinkTester has no public constructor TestCase(String name) or TestCase()
  warning(junit.framework.TestSuite$1): Class com.google.common.io.CharSourceTester has no public constructor TestCase(String name) or TestCase()
  testNulls(com.google.common.io.PackageSanityTests): Error in automated nulls test of class com.google.common.io.Files
If the class is better tested explicitly, you can add testNulls() to 
com.google.common.io.FilesTest
  warning(junit.framework.TestSuite$1): Class com.google.common.io.SourceSinkTester has no public constructor TestCase(String name) or TestCase()
  testInitialize(com.google.common.reflect.ReflectionTest): This test can't be included twice in the same suite. expected:<0> but was:<3>
  testNulls(com.google.common.util.concurrent.PackageSanityTests): Error in automated nulls test of class com.google.common.util.concurrent.Monitor
If the class is better tested explicitly, you can add testNulls() to 
com.google.common.util.concurrent.MonitorTest

Tests in error:
  testDefaultState(com.google.common.util.concurrent.SettableFutureTest)
  testSetValue(com.google.common.util.concurrent.SettableFutureTest)
  testSetFailureNull(com.google.common.util.concurrent.SettableFutureTest)
  testGoodCallableWithEnoughTime(com.google.common.util.concurrent.SimpleTimeLimiterTest)
  testGoodCallableWithNotEnoughTime(com.google.common.util.concurrent.SimpleTimeLimiterTest)
  testBadCallableWithEnoughTime(com.google.common.util.concurrent.SimpleTimeLimiterTest)
  testBadCallableWithNotEnoughTime(com.google.common.util.concurrent.SimpleTimeLimiterTest)
  testGoodMethodWithNotEnoughTime(com.google.common.util.concurrent.SimpleTimeLimiterTest): sleep interrupted
  testWeakImplementations(com.google.common.util.concurrent.StripedTest): Unexpected interrupt while waiting for latch
  testStrongImplementations(com.google.common.util.concurrent.StripedTest): Unexpected interrupt while waiting for latch
  testThreadFactoryBuilder_defaults(com.google.common.util.concurrent.ThreadFactoryBuilderTest)
  testThreadFactory(com.google.common.util.concurrent.ThreadFactoryBuilderTest)

Original issue reported on code.google.com by cpov...@google.com on 3 Apr 2013 at 5:05

Attachments:

GoogleCodeExporter commented 9 years ago
Oh, and I meant to offer this performance comparison:

before:
[INFO] Guava Unit Tests .................................. SUCCESS [7:22.145s]

after:
[INFO] Guava Unit Tests .................................. FAILURE [16:31.442s]

Original comment by cpov...@google.com on 3 Apr 2013 at 5:05

GoogleCodeExporter commented 9 years ago
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<issue id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:12

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:08