Fix message size and game over detection method

Bam4d / python-microRTS

A python client library for microRTS.

Apache License 2.0

19 stars 5 forks source link

Fix message size and game over detection method #3

Closed douglasrizzo closed 5 years ago

douglasrizzo commented 5 years ago

This PR makes the message size larger (from 4096 to 8192 bytes), as states with many entities were being truncated and sent in two messages, making it impossible to read a single message as a JSON file.

Also, the way python-microRTS detects a game over has been changed, since it detected the game was over before even sending the first action.

I believe the second point fixes #2 while the first point was an intermediate bug I found on the way.

douglasrizzo commented 5 years ago

I realized the way I fixed this problem is not the best one and found a few problems with it. I have already fixed them and plan on creating another PR soon.