search

BamaCharanChhandogi / Diabetes-Prediction

This website provides a platform for users to predict their likelihood of developing diabetes based on various factors.
https://diabetes-prediction-gamma.vercel.app/
MIT License
16 stars 41 forks source link

added socials and quick links #36

Closed Asymtode712 closed 1 month ago

Asymtode712 commented 1 month ago

Fixes #34

@BamaCharanChhandogi I have added a "/contact" route in quick link as a reference from #33 , so merge this PR first then go for my PR

Also, please add labels and assign me this PR

Thank you!

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
diabetes-prediction ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 6:11pm
BamaCharanChhandogi commented 1 month ago

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Asymtode712 commented 1 month ago

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

BamaCharanChhandogi commented 1 month ago

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

I have already reviewed workflow PRs. You need to update something. Please look at the PR.

Asymtode712 commented 1 month ago

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

I have already reviewed workflow PRs. You need to update something. Please look at the PR.

@BamaCharanChhandogi I checked each PR but there are no requested changes or updation by you

they are only reamaining with merge

BamaCharanChhandogi commented 1 month ago

@BamaCharanChhandogi till the time please merge my remaining workflow PRs

I have already reviewed workflow PRs. You need to update something. Please look at the PR.

@BamaCharanChhandogi I checked each PR but there are no requested changes or updation by you

they are only reamaining with merge

Do you see this type of review? image

Asymtode712 commented 1 month ago

@BamaCharanChhandogi No, should I change the PATs?

BamaCharanChhandogi commented 1 month ago

@BamaCharanChhandogi No, should I change the PATs?

yes

BamaCharanChhandogi commented 1 month ago

image

Do you see this review? any update?

Asymtode712 commented 1 month ago

@BamaCharanChhandogi No, I saw it now will make the changes quickly

Asymtode712 commented 1 month ago

@BamaCharanChhandogi Done with the changes

BamaCharanChhandogi commented 1 month ago

I do not know why my reviews are not visible to you. I just wanted to let you know that I requested more changes.

  1. why do you use a, I said that you must use the Link tag in pages.
  2. you can add rest page links according to the navbar.
Asymtode712 commented 1 month ago

@BamaCharanChhandogi I will replace all the occuraces of a with Link but for navigation from footer we dont have any About page at the moment right so where should I navigate About to?

Asymtode712 commented 1 month ago

@BamaCharanChhandogi I have replaced all instances of a with Link and for now About in footer navigates to Home page

BamaCharanChhandogi commented 1 month ago

@BamaCharanChhandogi I have replaced all instances of a with Link and for now About in footer navigates to Home page

You can add FAQ section instead of about

Asymtode712 commented 1 month ago

@BamaCharanChhandogi Ok as you say

Asymtode712 commented 1 month ago

@BamaCharanChhandogi Done with the changes please review