BanManagement / BanManager

A plugin for Minecraft to manage punishments and moderate more effectively
https://banmanagement.com/
Other
116 stars 90 forks source link

Remove rewriteBatchedStatements property #957

Closed A248 closed 2 years ago

A248 commented 2 years ago

Fixes #955

A248 commented 2 years ago

Interesting to see a test relating to IP range bans failed because of this. It may be a bug in MariaDB-Connector; we'll have to find out.

Recall that the removal of the rewriteBatchedStatements property will have two results: firstly, it will disable the feature of rewriting batched statements in and of itself. Secondly it will enable useServerPrepStmts.

A248 commented 2 years ago

I see you re-ran the tests. Since they passed, I hope the previous failure is not indicative of a real issue in MariaDB-Connector, BanManager, or even MariaDB. If it is, then it may be a difficult bug to solve.

Granted, the version of MariaDB used by MariaDB4j is somewhat outdated. I myself used to rely on MariaDB4j in LibertyBans, before recently switching to use docker-maven-plugin to create a temporary database. I'm slightly off-topic here, I realize, but perhaps you'd like to consider doing the same -- I'd permit you to re-use the configuration from the LibertyBans build for the BanManager build. You'd need to adjust it to your needs, however, seeing as BanManager will be using Gradle and seeing that you have a different approach to creating a test matrix (running independent Github workflows for each database, rather than testing all databases in the same build).