search

Banalian / ExtraLeaderboardPositions

Trackmania Next (2020) Plugin to see more key positions on the leaderboard
3 stars 8 forks source link

Add option to use regional leaderboards #41

Open SolidTux opened 2 months ago

SolidTux commented 2 months ago

It would be nice to be able to add the times from regional leaderboards. For example, instead of showing top 1, 10, 100, ... world, it could be interesting to have top 10 world, top 10 continent, ... or whatever other mixture.

Banalian commented 2 months ago

Iirc there's limitation with the API, I'd need to change the external Api's account to get that info, so that's not doable, I might only be able to do it if you're not using the external api, but that means it would only work if your time is worse than the requested position. Maybe doable, but quite the assle 😅

SolidTux commented 2 months ago

It does work, but is a bit slow. Personally, I would be fine with that caveat, but there should be a proper warning (maybe the setting could be hidden behind a toggle by default?).

Banalian commented 2 months ago

oof I see that PR yeah, I had forgotten about that other caveat x), doing a binary search is a solution, but not idea at all, + apart from being slow, I'd need to implement some delay between calls, because that would be quite the spam otherwise 😅 . Thanks for the PR still! I'm not working on the project rn, but that's definitively something I'll look into when I'll come back to it in a few weeks!

SolidTux commented 2 months ago

Great! Let me then know if there's something I could help with!

At least the top 5 should definitely be not an issue as they can be obtained with a single call.

SolidTux commented 2 months ago

Otherwise, I might be willing to set up some external service that keeps regional leaderboards for selected tracks (by getting the full global leaderboard and mapping the players to regions). But that, of course, would have the drawback that it probably would not be updated on demand.