Put NBTTagEnd into classCache

BananaPuncher714 / NBTEditor

A single class NBT editor for items, skulls, mobs, and tile entities

MIT License

138 stars 29 forks source link

Put NBTTagEnd into classCache #17

Closed LOOHP closed 3 years ago

LOOHP commented 3 years ago

On 1.17, since NBTTagEnd is not put into classCache, NBTEditor tries to find it with the path net.minecraft.server.v1_17_R1.NBTTagEnd which is incorrect. This PR does just that.

BananaPuncher714 commented 3 years ago

Thanks! What methods or such did you call that looked for NBTTagEnd? I don't think it was used in previous versions but I didn't extensively test every case.

LOOHP commented 3 years ago

I ran into the error by using contains(Object, String...) It didn't cause any problems in the past is probably due to the getNMSClass being able to find the class on every execution, tho since 1.17 repackaged nms classes it is unable to.

BananaPuncher714 commented 3 years ago

Yes, that definitely does seem to be an oversight on my part. 😛

LOOHP commented 3 years ago

Awesome Utility nevertheless! :P