search

Bananamilk452 / better-ytsr

Better filter experience on ytsr
1 stars 0 forks source link

Mistake in codes #1

Closed JayXie9499 closed 2 years ago

JayXie9499 commented 2 years ago

At index.js line 20: key = key.toLowerCase()

this causes error when sortBy and uploadDate filters are used

Bananamilk452 commented 2 years ago

Thank you for bug report! I will check code and fix in few hours.

Bananamilk452 commented 2 years ago
JayXie9499 commented 2 years ago

my codes

const ytsr = require("better-ytsr");

async function search(query) {
  const res = await ytsr(query, {
    filters: {
      sortBy: "Relevance"
    }
  });

  console.log(res);
}

search("ncs");

error

      const value = option[key].toLowerCase();
                                ^

TypeError: Cannot read properties of undefined (reading 'toLowerCase')
    at parseSP (C:\Users\jay95\Desktop\Projects\Bots\Musify\node_modules\better-ytsr\lib\index.js:28:33)
    at main (C:\Users\jay95\Desktop\Projects\Bots\Musify\node_modules\better-ytsr\lib\index.js:44:47)
    at search (C:\Users\jay95\Desktop\Projects\Bots\Musify\test.js:4:21)
    at Object.<anonymous> (C:\Users\jay95\Desktop\Projects\Bots\Musify\test.js:13:1)
    at Module._compile (node:internal/modules/cjs/loader:1095:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1147:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:17:47
Bananamilk452 commented 2 years ago

fixed in 1.1.1. please update to latest version,

npm