API - clean up

[shaiweeeen]

• [x] clean all Messages in services, specify errors

• [x] clean methods. Apply GeneralViewModel

  • use IntIdViewModel for all methods that only uses Id from the model
  • use StringIdViewModel for all methofs that only uses Id(from user) from the model
  • use StringSearchViewModel for all methods that only uses a string StringKey to search
  • useStringOptionSearchViewModel for all methods that uses a SearchKey and Option to search

• [x] Examine context queries in services. Make sure entities with associated foreign keys include the other tables in the query. (This is like JOIN when executing pure SQL) example: When getting Enrolled Students from Course Enrollment table (junction table of students and offered courses), make sure to include the Students entity (this is the navigator property that we put in models) so that we can access the properties of the student such as Id, Name...

Be mindful not all needs Include.

We don't want to return data that will not be used. Analyze the system, if you are unsure, just create an issue and label: bug ... title should be API-Include: [add very short description] and I will review.

• [x] report other errors as individual issue(label: bug)

This is without Role implementation yet

[shaiweeeen]

@xlawan kani lng nya unaha

[xlawan]

Modified Services and Controllers:

Announcement AnnouncementComment Course CourseEnrollment Issue

[xlawan]

Checked and modified messages and applied GeneralViewModel on these files: IssueComment - was not able to test (can't add data to the database yet) OfferedCourse PublicResearchRepository - was not able to test (can't add data to the database yet)

These files was changed to display joined tables: Announcement AnnouncementComment IssueComment

[xlawan]

Modified to show Foreign keys: User PublicResearchRepository Issue

Modified to connect with GeneralViewModel PublicResearchRepository

[shaiweeeen]

This is how to query specific properties from tables with foreign keys and navigators: var result = await _context.UserLogs .Select(x => new { UserId = x.User.Id, UserName = x.User.UserName, Idno = x.User.Idno, FullName = x.User.FullName, UserLogId = x.Id, // Include other properties from UserLog entity as needed }) .ToListAsync();