search

BandarHL / BHTwitter

Awesome tweak for Twitter
1.81k stars 103 forks source link

Chaning Twitter Blue Badge Color #112

Closed ExTBH closed 1 year ago

ExTBH commented 1 year ago

Closes #107

ExTBH commented 1 year ago

could be replaced with a Color picker or another icon https://github.com/BandarHL/BHTwitter/blob/f378082b499477298b04c0a8131ae9bd3698f3de/BHTwitter/BHTwitter.x#L719-L721

ExTBH commented 1 year ago

This hook is for timeline only, haven't wrote a threads hook

BandarHL commented 1 year ago

In profile view controller it just NSAttributedString with icon NSTextAttachment. But you’re code in the timeline it make it laggy I believe there is a better way to do it

ExTBH commented 1 year ago

i don't notice performance loss with it enabled/disabled but i could dig deeper

ExTBH commented 1 year ago

@BandarHL can you try this? 1 hook for timeline and threads, reduced checks it looks to also work on posts on the profile, but still doesnt work on the profile header edit: i am noticing a false positive from https://twitter.com/jakepaul i can't replicate on another profile idk why