BandarHL / BHTwitter

Awesome tweak for Twitter
1.79k stars 95 forks source link

"Advanced Search" Date Filter Flips from "On or Before" to "Since" on Edit #178

Open james-banks opened 11 months ago

james-banks commented 11 months ago

Description:

While using the "Advanced Search" feature of BHTwitter, I noticed a bug with the date condition. If a user selects to filter tweets "on or before" a certain date and later goes back to modify the date, the condition changes to "since" that date. This unintentional switch can lead to incorrect search results.

Steps to Reproduce:

  1. Open BHTwitter and navigate to the "Advanced Search" feature after activating it in the BHTwitter settings.
  2. Add a condition to filter tweets "on or before" a specific date.
  3. Execute the search to verify the correct filter is applied.
  4. Return to the "Advanced Search" conditions.
  5. Edit the previously set date for the "on or before" condition (or leave as it was) and click “Search”
  6. Observe that the condition now reads "since" the date.

Expected Behavior:

When a user edits the date for an "on or before" condition, the condition should remain "on or before" and not change to "since".

Actual Behavior:

After editing the date for an "on or before" condition, the condition changes to "since" the selected date.

Environment:

Additional Information:

Potential Impact:

This bug can lead users to retrieve incorrect search results, which can affect the overall user experience and the reliability of the "Advanced Search" feature.

Suggested Fix:

Ensure that the state of the date filter condition is retained when editing the date, so it remains consistent with the user's original choice.

Screenshots:

Ignore that the search wasn’t actually executing correctly here, I have verified that these advanced search tools can work as expected.

317EA99B-A23B-4AB1-A357-2D90B5B47858 3E514CDB-931A-496B-B29F-BB169C6876E9 84A0444A-36F6-4A4B-8591-2354D23FA5EA 484D6700-F309-449F-9B8E-446B47D9BD77