search

BandarHL / BHTwitter

Awesome tweak for Twitter
1.86k stars 212 forks source link

add vxtwitter copy option #198

Closed 8times4 closed 8 months ago

8times4 commented 10 months ago

Hey Bandar,

This might not be a fully working solution as I'm having Sonoma issues and can't build it, but in theory, this would add support to vxtwitter copy instead of the regular twitter/x copy. This can be useful, since every other day Twitter decides to disable link previews, which is kinda annoying, as I know my friends would just rather see the post than click on it.

VXTwitter comes from: https://github.com/dylanpdx/BetterTwitFix

Thanks! -8x4

BandarHL commented 9 months ago

Okay, thanks im going to try it

AuroraWright commented 9 months ago

I tested this and it works! (thanks!)

8times4 commented 9 months ago

Might be more beneficial to have a dropdown to toggle between vxtwitter and fxtwitter ( 2 different implementations, end goal is the same but some people prefer one over the other since niche features) - however I lack the skills to implement that :)

BandarHL commented 9 months ago

I really have much time to implement all of that, @8times4 if you can pull the lasted commit of BHTwitter and implement the feature because there is a conflicting with this current pull

AuroraWright commented 9 months ago

This is @8times4 's patch against latest master bhtwitter.patch (fwiw in the Makefile I had to change TARGET := iphone:clang:latest:14.0 to TARGET := iphone:clang:16.5:14.0to build with latest xcode, I think it tries to use the official 17.0 SDK instead of the theos ones and fails to build when linking otherwise)

BandarHL commented 8 months ago

it should be in the next update, thanks