Bandov / pe

0 stars 0 forks source link

Names can include numbers #3

Open Bandov opened 5 months ago

Bandov commented 5 months ago

Feature Flaw (Severity Low) Steps to reproduce

  1. Input /add-person ; name : 12345678 ; phone : 98765435 ; address : Poochie Street 24 ; email : ihelppooches@gmail.com

Expected Error message to be shown that name is only a number

Actual No error message shown and the user is added to the addressbook

Screenshot 2024-04-19 at 4.28.07 PM.png

nus-pe-script commented 5 months ago

Team's Response

This was an intentional feature since it is possible to have a name with numbers, for example, Elon Musk's child XÆ 12.

Additionally, it is not a feature flaw since it does not value add to disallow such naming formats. However, our current implementation does value add as it enhances the flexibility and usability of our application for the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In most conventional uses, a person's name is expected to be alphabetic. Allowing numerical-only entries for names without clear restrictions can lead to data integrity issues, where the name field is populated with unintended information like identification numbers, leading to confusion or misuse.

Good data validation practices dictate that fields should be restricted according to their expected content. Names, traditionally consisting of alphabetical characters, should be validated as such to prevent errors or misuse of the field. Furthermore, from this excerpt, it is said that in the US, such names are not allowed to contain numerals by law.

Screenshot 2024-04-24 at 10.24.16 PM.png

Not providing clear validation rules can lead to a user interface that is not self-explanatory, potentially reducing the application's usability.

In professional settings, it's unlikely for individuals to have names that are solely numeric. By allowing such entries, the application risks not being taken seriously or deemed not fit for professional use.

In summary, while flexibility in name input might be seen as inclusive, without clear rules and validation, it could be perceived as a lack of attention to data quality and standards. It’s essential for an application to enforce logical restrictions on user inputs to maintain the integrity and usefulness of the data. Thus, if the system is intended for general or professional use where person names are typically alphabetic, accepting names with only numbers should be considered a feature flaw.