Bandov / pe

0 stars 0 forks source link

Unable to add a valid leap year using deadline #7

Open Bandov opened 2 months ago

Bandov commented 2 months ago

Functionality Bug (Severity MEDIUM) Steps to reproduce

  1. Input /note ; name : 1 ; note : get 10kg of matcha from moochie ; deadline :40000-02-29

Expected for the deadline to be added to the person with name 1.

Actual Error message shown despite 40000-02-29 being a valid leap year date Screenshot 2024-04-19 at 4.43.05 PM.png

nus-se-script commented 2 months ago

Team's Response

This is the correct intended behaviour since your input uses 5 digits for the year, though the correct format only accepts 4 digits. The correct format that you should use can be seen in both the error message and the UG. Additionally, any form of input that accepts 5 digits is not realistic as a deadline in our current time period and is likely to be a typo from the user side, hence it is valid, and in fact, value adding since we catch such errors.

Additionally, we believe that such an input is a rare scenario (a few 10000 years in the future) and do not affect the usability of the product as a whole. Hence, even if this "issue" is accepted, we will be lowering the severity of the issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]