Bandov / pe

0 stars 0 forks source link

Unable to add of rating 01 #8

Open Bandov opened 2 months ago

Bandov commented 2 months ago

Functionality Bug (Severity LOW) Steps to reproduce

  1. Input /rate ; name : Janna ; rating : 01

Expected Rating of person Janna to have one star Actual Error message shown despite not having any place in documentation where 01 is not allowed despite it being equal to value 1. Screenshot 2024-04-19 at 4.46.48 PM.png

nus-se-bot commented 2 months ago

Team's Response

In the user guide, it is clearly stated that you should specify from "0" to "5". “01”, although technically within the range, is invalid on the following grounds:

  1. Leading zeroes are normally prepended in cases where the acceptable values are of a fixed length (e.g. if the acceptable range is from 0-99, then it makes sense to accept leading zeroes for 0-9). However since our acceptable values are all single digits, it does not make sense to prepend leading zeroes as there will never be a case where the first digit is nonzero.
  2. Furthermore, for fast typists, we believe that they would not go through the trouble to add an additional "0" in front as it is inefficient.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Not accepting numeric input with a leading zero, like "01," can be considered a functionality bug due to user interface consistency, common user experience, and inclusive design principles. Users expect software to handle numerical inputs uniformly, often disregarding leading zeros. If the software rejects such input without clear documentation, it can lead to confusion and a subpar user experience. The UG does not explicitly state anywhere that having a leading 0 in front of a digit is not allowed. They also reinforce the users misunderstanding that they accept any form of input as long as it is a whole number value from 0 to 5 inclusive as seen in the UG and the error message. Thus, with my context and background, the user might expect leading zeros to be supported by the app. As seen below.

Screenshot 2024-04-24 at 11.04.54 PM.png

Furthermore, error messages must clearly instruct users on proper input formats. As a user, seeing the error message below would confuse me as to me 01 means 1 and is not violating any rules as spelled out in the error message.

Screenshot 2024-04-24 at 11.02.52 PM.png

This is further supported by the fact that 01 and 1 are of equal value and thus 01 meets the requirements that is set up by the UG and the error message. See below for proof.

Screenshot 2024-04-24 at 11.12.18 PM.png

Lastly, leading zeros may be standard practice in some regions. Therefore, the application should either accept leading zeros in numeric input or explicitly state in the documentation that they are not permitted. Which neither was done.