search

Bandwidth / node-numbers

Node SDK for Bandwidth Numbers
https://dev.bandwidth.com
MIT License
1 stars 5 forks source link

numbers.Order is a function. #11

Open izakfilmalter opened 4 years ago

izakfilmalter commented 4 years ago

Very curious as to why numbers.Order is an empty function.

Busy making TypeScript types for the lib and reading through the code. Seems like this happen a lot in this lib where the top level item in the api is an empty function. I feel like this probably creates a lot of confusion for users.

function Order(){
}
dtolb commented 4 years ago

Not the original author here; so I can't comment with 100% certainty. I can only guess it made sense at the time and you're the first to bring up as it's mostly worked since then with minimal confusion.

izakfilmalter commented 4 years ago

It's just that other top level apis are objects, so was more looking at it from a consistency pov.