search

BandwidthOnDemand / nsi-safnari

A NSI Aggregator Coordinator
BSD 3-Clause "New" or "Revised" License
4 stars 0 forks source link

Service specific errors generated by PCE not propagated to requester. #12

Closed jmacauley closed 10 years ago

jmacauley commented 10 years ago

Service specific errors generated by PCE are not being propagated to the requester in serviceException. It looks like safnari is attempting to get the the findPath version 1 error message instead of the v2 one. As a result, only a generic 00403 error is ever sent back to the requester.

I have updated the PCE to return a structure that should be easier to map through to the serviceException:

{
    "correlationId": "d7d0196b-58f2-475c-9995-be9108772b4a",
    "status": "FAILED",
    "m.findPathError": {
        "code": "00702",
        "label": "STP_RESOLUTION_ERROR",
        "description": "Could not resolve STP (urn:ogf:network:uvalight.net:2013:ps?vlan=1784).",
        "variable": {
            "@type": "sourceSTP",
            "@namespace": "http://schemas.ogf.org/nsi/2013/12/services/point2point#p2ps",
            "value": "urn:ogf:network:uvalight.net:2013:ps?vlan=1784"
        }
    }
}

I hope this helps.

John

hanstrompert commented 10 years ago

added link to this issue to related task on backlog: https://app.asana.com/0/5105330979296/14425943621188

bjpbakker commented 10 years ago

Commit 4832da1 fixes this.