search

BanhmiDev / admob_consent

This is a wrapper for Google's User Messaging Platform (UMP) SDK in Flutter
https://pub.dev/packages/admob_consent
Apache License 2.0
12 stars 11 forks source link

onConsentInfoUpdateSuccess null pointer crashes reported on Android devices #9

Open paul678 opened 3 years ago

paul678 commented 3 years ago

Hi,

First I'd like to say thanks for the work, I've released my app using your plugin for displaying UMP GDPR message for Android users (and IDFA for iOS). The update was released on 28.01.2020 and as of now the crash rate increased from 0.0 to 0.87 crashes per 1k devices (currently gathered from ~1.5k active updates). That's a pretty big increase which I'll start monitoring but for now find below my conclusion after checking the crash logs:

Crash logs from Android 9 and 10 (all Samsung devices: S8, S8+, S9+, A51, A71) java.lang.NullPointerException: at com.anteger.admob_consent.AdmobConsentPlugin$1.onConsentInfoUpdateSuccess (AdmobConsentPlugin.java:9) at com.google.android.gms.internal.consent_sdk.zzu.run (zzu.java:2) at android.os.Handler.handleCallback (Handler.java:883) at android.os.Handler.dispatchMessage (Handler.java:100) at android.os.Looper.loop (Looper.java:237) at android.app.ActivityThread.main (ActivityThread.java:8167) at java.lang.reflect.Method.invoke (Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:496) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1100)

I've checked your code and my only idea would be the consentInformation to be null. The Documentation for UMP said nothing of this case so I'm not sure how is that possible.

As of now I've not been able to reproduce this crash on a S10e.

paul678 commented 3 years ago

@Gimu Checked again and it seems I get a similar crash on one f the other callbacks:

java.lang.NullPointerException: at com.anteger.admob_consent.AdmobConsentPlugin$2.onConsentInfoUpdateFailure (AdmobConsentPlugin.java:22) at com.google.android.gms.internal.consent_sdk.zzt.run (zzt.java:8) at android.os.Handler.handleCallback (Handler.java:883) at android.os.Handler.dispatchMessage (Handler.java:100) at android.os.Looper.loop (Looper.java:237) at android.app.ActivityThread.main (ActivityThread.java:8107) at java.lang.reflect.Method.invoke (Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:496) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1100)

Asked a friend to use the app on an S9 and an S20+ and both are ok.

jj-hoeksema commented 3 years ago

I can confirm this for my application aswell. Both onsucces and onfailure are impacted. I would like to add some info from my crash analytics:

70 % are samsung devices, but a lot of other devices aswell. Reports for android 8, 9, 10 and 11. Interesting fact 93% of the crashes is while the app is in the background.

Let me know if you need help locating the issue.

samlotti commented 3 years ago

I'm also getting these issues on my application.