search

Banjerr / Grateful-ness

Simple journal PWA built with Svelte and IndexedDB
https://vigorous-lovelace-e8f335.netlify.app/
The Unlicense
2 stars 4 forks source link

Some type of entry search #8

Open Banjerr opened 5 years ago

Banjerr commented 5 years ago

A simple fuzzy search to look for stuff in the title/body

ktsuench commented 5 years ago

I'd like to try this out :)

Banjerr commented 5 years ago

Awesome! I haven’t gotten any PR guidelines yet, but if you could just make a feature branch from “master” and then make a PR that would be great 🙏

Sent from my iPhone

On Oct 14, 2019, at 12:13 AM, Kent Tsuenchy notifications@github.com wrote:

 I'd like to try this out :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

petercr commented 5 years ago

Hey @ktsuench I didn't know if you had made any progress on this? Also I think we would have to build out a UI for the search, right?

Has anyone put any thought into that 🤔

Banjerr commented 5 years ago

I have not seen any progress on this so far. We would certainly need a simple UI layout for the search/results; but this could be super minimal as styling/look hasn’t really been thought out yet.

Sent from my iPhone

On Oct 25, 2019, at 9:03 PM, Peter Cruckshank notifications@github.com wrote:

 Hey @ktsuench I didn't know if you had made any progress on this? Also I think we would have to build out a UI for the search, right?

Has anyone put any thought into that 🤔

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

ktsuench commented 5 years ago

Nope, I've been busy with some other things but yes looks like we'll need a UI. I was just thinking of implementing the logic.