search

BanklessDAO / bankless-dao-website

[ARCHIVED] The repository for the frontend of https://www.bankless.community/
MIT License
38 stars 16 forks source link

Invariant Fix: Adds EthereumJS-abi as an npm package #57

Open wpmonty opened 3 years ago

wpmonty commented 3 years ago

This PR fixes the Netlify build issue linked to Ethereum ABI as a submodule It adds the abi package directly and flushes entire yarn.lock file

wpmonty commented 3 years ago

@wpmonty looks like the yarn.lock has a conflict because of the ENS & Wallet Modal. Can you take a look?

tbh I'm not sure that this is still an issue; have you been updating your yarn.lock files per the readme? If not, I think we would have seen it break builds already.

Oktalize commented 3 years ago

@wpmonty looks like the yarn.lock has a conflict because of the ENS & Wallet Modal. Can you take a look?

tbh I'm not sure that this is still an issue; have you been updating your yarn.lock files per the readme? If not, I think we would have seen it break builds already.

This is a result of tons of changes to the yarn.lock from adding in dependencies for ENS. I checked it then and checked it again just now, the yarn.lock lines mentioned in the README are unchanged.

It looks like this PR includes a "flush of yarn.lock" which is removing a bunch of lines where ENS gets added in. The ENS change was quite a large chunk of the yarn.lock but it is impossible to review every line.

I am attaching a screenshot of what I am talking about, the "Incoming changes" from this PR are on the right, the conflict appears to be most of the lines that occur where ENS dependencies were added.

CleanShot 2021-07-05 at 11 08 34