Convert Movement packets from per second to send on change

[garrettluskey]

For New Contributors

How to contribute

Description

Right now the movement is being sent at a set rate.

In the Agent service create MovementEvents and handles sending and receiving of movement packets.

A MovementEvent is when an Agent controlled by the client any of the following are changed:

• MovementInputVector
• LookDirection
• ActionData
• MountData

On a MovementEvent

• Create a new packet with only the data that has been changed
• This movement packet should not send more than 30 times per second (this 30 seconds should be easily configurable).

For any new events, use the already existing MessageBroker.

Intended Design

N/A

Location

Create a branch based from arena-vertical-slice In the Agent service under the Missions project Services folder

Related Issues

Blocked by #467

Requirements

• No more than 30 messages per second for a single agent shall be sent.
• Only values that have changed since the last sending packet shall be packaged into a packet and sent over the network.

Additional information

N/A

Definition of Done

• [ ] Class level comments exist for all new classes.
• [ ] XUnit tests exist for every method that does not require the game to be ran.

[Ciel1996]

I assume that MovementEvent is currently called MovementPacket. Searching for MovementEvent on the branch does not find anything.

[garrettluskey]

MovementEvent currently does not exist. I updated the description to be more helpful

[Ciel1996]

I'm currently replacing the polling mechanism of MovementHandler by an event-based mechanism. Should only movement related packets be rate-limited or all packets? If all, I would implement the rate-limit at MessageBrokerlevel. Otherwise I would implement it in the MovementHandler.

[Ciel1996]

Come to think of it, implementing it inside the MovementHandler is probably best and the only viable solution.

[Ciel1996]

So I have made some further progress and I noticed that theoretically the Agent Equipment could also change during a battle. Should I also respect this or is this handled somewhere else? In my opinion it could be sent with the rest of the movement deltas

[garrettluskey]

All of the respective data in this scope is sent via a movement packet and is not necessarily reliable. For reliable events we plan on using INetworkEvents such as Agent Equipment changing