Bannerlord-Coop-Team / BannerlordCoop

MIT License
269 stars 51 forks source link

Sync: TraitObject Properties #952

Closed garrettluskey closed 3 months ago

garrettluskey commented 3 months ago

Description

  1. Sync the values in the Synced list below.
  2. Create an end to end (E2E) tests for all properties (1 for server changing the value and 1 for client changing the value if applicable)
  3. Create a command to test changing each property in game see similar command

Also see additional information at the bottom for more information and templates

Key Server side only (only allow the running of the function on the server side) Client side only (only allow the running of the function on the client side) Client side sync (request the server to change the value, server then changes the value and replies to the client allowing the change) Server side sync (only server allows running of the function and send to all clients the value changed and clients update the value/call original function)

Synced

Method/Field Name Sync Type Additional Information
TODO TODO

Deferred

None

Externally Deferred

IsHidden, MaxValue & MinValue are covered by the Lifetime of the object as they are only set on initialize.

Non-Synced

None

Intended Design

You are expected to only sync the property setters. Try using the new autosync tool

Location

Create a branch based from development

Related Issues

Blocked by:

Requirements

N/A

Additional information

Using the GameInterface Service Tempale create commands to test the synced values.

Definition of Done

EgardA commented 3 months ago

Handled in Lifetime, only set on init