Bannerlord-Coop-Team / BannerlordCoop

MIT License
269 stars 51 forks source link

Sync: TraitObject Collections #953

Closed garrettluskey closed 3 months ago

garrettluskey commented 3 months ago

Description

  1. Sync the values in the Synced list below.
  2. Create an end to end (E2E) tests for all collections (1 for server changing the value and 1 for client changing the value if applicable)
  3. Create a command to test updating the collection in game see similar command

Also see additional information at the bottom for more information and templates

Key Server side only (only allow the running of the function on the server side) Client side only (only allow the running of the function on the client side) Client side sync (request the server to change the value, server then changes the value and replies to the client allowing the change) Server side sync (only server allows running of the function and send to all clients the value changed and clients update the value/call original function)

Synced

Collection Name Sync Type Additional Information
TODO TODO TODO

Deferred

None

Externally Deferred

None

Non-Synced

All

Intended Design

For the patch itself please refer to https://github.com/Bannerlord-Coop-Team/BannerlordCoop/wiki/Patching-Basics#collection-patching

Collection Sync Dataflow CollectionSyncDataflow Integration Testing image

Location

Create a branch based from development

Related Issues

Blocked by:

Requirements

N/A

Additional information

Using the GameInterface Service Tempale create commands to test the synced values.

Definition of Done

EgardA commented 3 months ago

Only a default collection