Please check if your PR fulfills the following requirements:
[ ] All new classes have class-level documentation comments, if there are any at all
[x] Tests for the changes have been added (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bug fix (non-breaking change that fixes an issue)
[x] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation update
[ ] Other... Please describe:
What is the current behavior?
BesiegerCamp not synced :(
What is the new behavior?
BesiegerCamp synced :)
It was also necessary to sync SiegeEnginesContainer(lifetime, props) and SiegeEngineConstructionProgress(lifetime).
All E2E for fields, props and collections are passing, seemingly no (new) crashes.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
BesiegerCamp not synced :(
What is the new behavior?
BesiegerCamp synced :)
It was also necessary to sync SiegeEnginesContainer(lifetime, props) and SiegeEngineConstructionProgress(lifetime). All E2E for fields, props and collections are passing, seemingly no (new) crashes.
Resolves #836 Resolves #837 Resolves #838 Resolves #1001
Resolves #1003
Other information
Synced Fields:
BesiegerCamp:
SiegeEnginesContainer:
SiegeEngineConstructionProgress: