Bannerlord-Coop-Team / BannerlordCoop

MIT License
269 stars 51 forks source link

Sync BesiegerCamp #977

Closed brodrigz closed 1 month ago

brodrigz commented 2 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

BesiegerCamp not synced :(

What is the new behavior?

BesiegerCamp synced :)

It was also necessary to sync SiegeEnginesContainer(lifetime, props) and SiegeEngineConstructionProgress(lifetime). All E2E for fields, props and collections are passing, seemingly no (new) crashes.

Resolves #836 Resolves #837 Resolves #838 Resolves #1001
Resolves #1003

Other information

Synced Fields:

BesiegerCamp:

Field Name Sync Type Additional Information
_leaderParty Server side AutoSynced
Property Name Sync Type Additional Information
NumberOfTroopsKilledOnSide Server side AutoSynced
SiegeEvent Server side AutoSynced
SiegeEngines Server side AutoSynced
SiegeStrategy Server side AutoSynced
Collection Name Sync Type Additional Information
_mobileParties Server side AutoSynced

SiegeEnginesContainer:

Created Lifetime patches/handler

Field Name Sync Type Additional Information
SiegePreparations Server side AutoSynced

SiegeEngineConstructionProgress:

Created Lifetime patches/handler

Property Name Sync Type Additional Information
Progress Server side AutoSynced
Hitpoints Server side AutoSynced
MaxHitPoints Server side AutoSynced
Field Name Sync Type Additional Information
SiegeEngine Server side AutoSynced, ATM does nothing as SiegeEngineType is currently unmanaged
EgardA commented 1 month ago

Joke on vacation and I don't want to wait, merging.