Added E2E Test Check for Serialization - Githubissues

Bannerlord-Coop-Team / BannerlordCoop

MIT License

268 stars 51 forks source link

Added E2E Test Check for Serialization #989

Closed garrettluskey closed 1 month ago

garrettluskey commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] All new classes have class-level documentation comments, if there are any at all
[x] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bug fix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation update
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

The test environment now checks that messages sent over the network are serializable

Other information

EgardA commented 1 month ago

Looks good to me, waiting for tests to pass again