search

Banno / polymer-webpack-loader

WebPack Loader for Polymer Web Components
MIT License
192 stars 48 forks source link

Set module's assetpath attribute to fix component's importPath() #88

Open mjcctech opened 6 years ago

mjcctech commented 6 years ago

When component is loaded by polymer-webpack-loader it lose information about original path. Polymer provide importPatch property(https://www.polymer-project.org/2.0/docs/devguide/dom-template#urls-in-templates). But to work it correctly with webpack loader assetpath attribute should be set on module.

codecov[bot] commented 6 years ago

Codecov Report

Merging #88 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   97.02%   97.04%   +0.02%     
==========================================
  Files           2        2              
  Lines         269      271       +2     
  Branches       65       67       +2     
==========================================
+ Hits          261      263       +2     
  Misses          8        8
Impacted Files Coverage Δ
src/index.js 97.4% <100%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 80e56e2...5c29a92. Read the comment docs.

codecov[bot] commented 6 years ago

Codecov Report

Merging #88 into master will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   97.02%   97.04%   +0.02%     
==========================================
  Files           2        2              
  Lines         269      271       +2     
  Branches       65       67       +2     
==========================================
+ Hits          261      263       +2     
  Misses          8        8
Impacted Files Coverage Δ
src/index.js 97.40% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf8fa98...5c29a92. Read the comment docs.