Baoqi / metabase-dremio-driver

Dremio driver for Metabase BI
Eclipse Public License 2.0
47 stars 10 forks source link

Issue with filter on date with metabase 0.46 #9

Closed urba1n closed 1 year ago

urba1n commented 1 year ago

While testing metabase 0.46.0-RC4, a query with a filter (last 12 months) on a timestamp is not working anymore. Here is the error:

Not supported by Honey SQL 2: ^honeysql.types.SqlCall (honeysql.core/call :timestampadd #sql/raw "month" -12 [:metabase.util.honey-sql-2/typed [:cast [:metabase.util.honey-sql-2/typed :%now {:metabase.util.honeysql-extensions/database-type "timestamptz"}] [:raw "timestamp"]] {:metabase.util.honeysql-extensions/database-type "timestamp"}]) Similar filter on mysql databases are fine, so it could be releated to the driver.

Driver interface has changed with 0.46 https://www.metabase.com/docs/master/developers-guide/driver-changelog

ghost commented 1 year ago

PR with fix: https://github.com/Baoqi/metabase-dremio-driver/pull/10

ghost commented 1 year ago

@urba1n

Link to download pre-release https://github.com/RonildoSS/metabase-dremio-driver/releases/download/1.1.2-alpha.1/dremio.metabase-driver.jar

urba1n commented 1 year ago

@RonildoSS Thank you very much, date filtering is working fine now.

rogercezidio commented 1 year ago

Working here too, thanks @RonildoSS

Baoqi commented 1 year ago

Fix with new release 1.2.0, Thanks all.

urba1n commented 1 year ago

Thanks @Baoqi