search

BaowenZ / RaDe-GS

RaDe-GS: Rasterizing Depth in Gaussian Splatting
Other
449 stars 23 forks source link

Usage of kernel_size in computeCov2D function of forward pass not consistent of with Mip-Splatting #50

Open vairleon opened 3 weeks ago

vairleon commented 3 weeks ago

I've noticed that in the forward pass, you've removed the cov[0][0] += kernel_size; cov[1][1] += kernel_size; from the computeCov2D function, compared with Mip-splatting or GOF. However, you did not remove the corresponding addition in the backward pass. I was wondering if there's a specific reason for this or if it's simply an oversight.

BaowenZ commented 3 weeks ago

Thanks for the reminder! I missed that when adding the 2D filter. I've updated the code now. While it's not used in our default settings (we don't include 2D filter in our experiments), it would blocking attempts to apply the 2D filter. Thanks again for your careful reading!

hiyyg commented 6 days ago

Hi, I wonder if we want to enable mip splatting's 2D filter, how should we change the config? Is it correct to set disable_filter3D=True and kernel_size=0.1?