search

Baqend / Orestes-Bloomfilter

Library of different Bloom filters in Java with optional Redis-backing, counting and many hashing options.
Other
843 stars 245 forks source link

Java 7 backport of your code #18

Closed Crystark closed 9 years ago

Crystark commented 10 years ago

Hi,

I've just finished backporting your code to java 7. Take a look at my branch port-java7. I can't suggest a pull request to a new branch on your side (there's no option in github for that) but I thought you might like to have it and it seems you could do this using command line.

The only discrepancies are the tests that used CompletableFuture which I haven't rewritten for java 7. Otherwise all tests pass. I haven't yet built it but I wanted to share this work early as it's already on github.

I think this may be usefull to people who can't yet afford to switch to Java 8. Please let me know what you think about it.

IlyaRakov commented 10 years ago

Thanks for port

DivineTraube commented 9 years ago

Thanks a lot for this great work! I'm sure this will be interesting for a lot of people. We created a link in the docs pointing to your backport.