I need Sentinel support and looking at the existing pool, it looks like changing to Pool and adding a constructor would allow the filters to be used in Sentinel instances.
I also added a constructor that includes an externally provide pool for integration with other users of Redis so we don't have too many open connections.
Ideas/looking for feedback
should I build a RedisPoolConfiguration class similar to the RedisSentinelConfiguration for consistency?
I see a pull request for SSL support. if I add RedisSentinelConfiguration I think it would make sense to add all new pool configuration settings to it, instead of expanding the set of Constructors.
what does the startThread logic do? I couldn't find any tests or where it is used. If needed, can you explain more about why you're creating an explicit Jedis instead of using a resource from the pool?
I've looked at Redis Cluster in Jedis enough to see I can't do the Pool change and have it work with Cluster too. Are you guys working on a refactoring that would work with any connection source?
Looking for feedback before adding tests.
I need Sentinel support and looking at the existing pool, it looks like changing to Pool and adding a constructor would allow the filters to be used in Sentinel instances.
I also added a constructor that includes an externally provide pool for integration with other users of Redis so we don't have too many open connections.
Ideas/looking for feedback
Thanks
Chris