Barbarian1010 / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

Minimum window size too big for netbook screens #624

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Use a screen resolution with 600 vertical pixels (e.g. 800x600 or, on a 
netbook, 1024x600)
2. Use gnome or any other sort of horizontal task bar that uses a bit of space
3. Open pychess and provoke the yellow info bar (which also eats up vertical 
space I suppose)

What is the expected output? What do you see instead?
http://eloxoph.com/minimumheight.png As seen here, the pychess window is a bit 
too big to fit on the screen. It is at the minimum size, so I cannot resize it 
to fit properly. If possible, maybe the minimum size could be changed so I can 
actually resize it to a smaller height? The contents still look spacey so I 
don't see why there should be a problem with allowing a smaller minimum height.

Does it happen every time?
yes

What version of the product are you using?
0.10rc1

Did you use an installed version of PyChess or did you run in from a
tarball/svn?
svn/hg retrieved on fri dec 31th 2010 (today)

Please provide any additional information below.

Please attach the latest pychess logfile. It's in a hidden folder, under
your homedirectory, named ".local/share/pychess/"

Original issue reported on code.google.com by jonas.thiem@gmail.com on 31 Dec 2010 at 9:27

GoogleCodeExporter commented 9 years ago

Original comment by gbtami on 4 Jan 2011 at 4:40

GoogleCodeExporter commented 9 years ago
Change lib/pychess/widgets/BoardView.py line 117 to: self.set_size_request(150, 
150)
That fixes the issue.

Original comment by jonas.thiem@gmail.com on 5 Sep 2012 at 4:34

GoogleCodeExporter commented 9 years ago
Sorry, line 118 actually. Should probably do a patch, but it's the only 
set_size_request in that file so shouldn't be too hard to find :-)

Original comment by jonas.thiem@gmail.com on 5 Sep 2012 at 4:35

GoogleCodeExporter commented 9 years ago
Seams reasonable. Will this leave enough space for the menu?
I'd say it is ok to not keep room for sidepanels.

Original comment by lobais on 8 Sep 2012 at 9:13

GoogleCodeExporter commented 9 years ago
Here it does. Anyway, the main problem is the window height, so you might 
simply increase the horizontal component of the size request a bit, while 
leaving the vertical one at 150.

Original comment by jonas.thiem@gmail.com on 8 Sep 2012 at 10:52

GoogleCodeExporter commented 9 years ago
Before we can resolve this issue, the chat panel also needs to be fixed.

The engine output bar also needs a bit of additional vertical space of course, 
but when disabling just the chat pane (so it goes invisible) and using all 
other panels in their default positions, I'm still able to make the window 
pretty small (vertically) so that I'm sure it will fit for everyone. But with 
the chat pane enabled, the PyChess window gets considerably taller for no 
apparent reason.

I have already examined the chat pane code but I have no idea why it wants so 
much vertical space.

Original comment by jonas.thiem@gmail.com on 8 Sep 2012 at 11:07

GoogleCodeExporter commented 9 years ago
It just dawned me it had the same issue as my engine output view :-) the 
ScrolledWindows have a large minimum vertical size, which can be easily changed 
to something smaller with set_size_request(-1, 40) or something like that.

I added that for the chat view aswell, and now I can have all panels visible 
and shrink the PyChess window to quite a decently small vertical size :-) while 
all panels are still readable (although less convenient than when being large 
obviously).

So my engine output clone should have this fixed.

Original comment by jonas.thiem@gmail.com on 8 Sep 2012 at 11:22

GoogleCodeExporter commented 9 years ago

Original comment by jonas.thiem@gmail.com on 18 Sep 2012 at 2:40