search

Barbosik / MultiOgar

An open source Ogar server implementation, written with Node.js.
Other
61 stars 44 forks source link

Possible issue with uws? #219

Open AdaptCharm opened 8 years ago

AdaptCharm commented 8 years ago

I am running the latest version of MultiOgar.

I have implemented and enabled uws from https://github.com/Barbosik/MultiOgar/pull/197

After 10 minutes of uptime (the server was running fine), I receive this error: http://prntscr.com/bv35t0

Can somebody please help me fix this error?

ghost commented 8 years ago

You cannot read the address of a disconnected socket. I should fix so that it doesn't fail like this, but you will get undefined as return value instead.

ghost commented 8 years ago

https://github.com/uWebSockets/uWebSockets/commit/2688bdd1f7da313b74f578b2d353f977fa3d49a3

AdaptCharm commented 8 years ago

@alexhultman Thank you

ghost commented 8 years ago

This is fixed in 0.7.9, you can test it out.

AdaptCharm commented 8 years ago

Hi,

Thank you for your reply.

I'm not sure how I upgrade mysql modules, so I implemented fixes from https://github.com/michaelmcmillan/LittList/issues/53 It seems like those mysql queries solved my issue. But there is a new issue. When I ran my servers tonight, and as soon as I woke up in the morning; only one of the servers was running.

Here is the new error I'm getting: http://prntscr.com/bvotbx

Can you help me solve this one as well? I'll pay you money if you're interested, even though I look at coding as art.

Thanks.

Yours sincerely, Jamie Isaksen

Sent from Mailbird [http://www.getmailbird.com/?utm_source=Mailbird&utm_medium=email&utm_campaign=sent-from-mailbird] On 21.07.2016 09.45.18, Alex Hultman notifications@github.com wrote: This is fixed in 0.7.9, you can test it out. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub [https://github.com/Barbosik/MultiOgar/issues/219#issuecomment-234180935], or mute the thread [https://github.com/notifications/unsubscribe-auth/AQ_ckPKGzckf6wqUZkNMsyIWLZ_oiDK3ks5qXyOGgaJpZM4JQaf_].

ghost commented 8 years ago

This is unrelated to uws right?

AdaptCharm commented 8 years ago

Well, I'm running my server with uws. So I suppose it might be related. Thanks

  1. jul. 2016 15:54 skrev Alex Hultman notifications@github.com:This is unrelated to uws right?

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 8 years ago

Sure but a lost mysql connection should be unrelated. They are completely separate. Unless more people are getting the same problem I wouldn't suspect uws.

AdaptCharm commented 8 years ago

Hmm, okay. Even if the problem might not be related with uws, can you help me fix it? Thanks.

  1. jul. 2016 16:03 skrev Alex Hultman notifications@github.com:Sure but a lost mysql connection should be unrelated. They are completely separate. Unless more people are getting the same problem I wouldn't suspect uws.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 8 years ago

What happens if you run it with ws instead? That would be first step of all. If you can reproduce it with ws then obviously theres no relation to uws.

AdaptCharm commented 8 years ago

I have never tried that.. Last night I started both of my servers with uws, then when I woke up this morning, one of them was down. Should I use ws on the other server? Then I restart the servers and check how long until one of them crashes? Thanks.

  1. jul. 2016 4:53 p.m. skrev Alex Hultman notifications@github.com:What happens if you run it with ws instead? That would be first step of all. If you can reproduce it with ws then obviously theres no relation to uws.

—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or mute the thread.

Barbosik commented 8 years ago

you need to monitoring for mysql connection and reconnect when it's disconnected.