BareMinimumStudios / RelicEx

Adds compatible trinket items for PlayerEx attributes.
MIT License
0 stars 3 forks source link

RelicEx Helmet and Chestplate Relics Will Not Affix to Helmet and Chestplate Armors #10

Open LightningFerix opened 2 months ago

LightningFerix commented 2 months ago

When you have a helmet and/or chestplate equipped and are holding a helmet or chest relic, if you crouch and right click the relic should become affixed to the helmet. However, this does not happen and the helm and chest relic will simply equip themselves like normal armor, replacing the armor you were already wearing.

bibi-reden commented 2 months ago

Hi, Can you try applying the relic through the anvil?

At the moment, applying through crouch & right-click is not present. I could apply some patch later or label it as something to do for the eventual rewrite of this mod.

LightningFerix commented 2 months ago

Tomorrow when I am on my server I will try using the anvil!

In the meantime could I suggest that the text on the Modrinth page be altered to reflect the fact that crouch right clicking does not affix the relic?

Also, if the anvil method works, I personally don't see any reason to necessarily add crouch right clicking to the mod, although that of course is ultimately up to your team!

LightningFerix commented 2 months ago

So it turns out that the anvil does work. My only complaint is that after being combined, the armor description does not reflect the new stat increases it gained from the relic and there is no way to tell what the bonuses were nor any way to know that this armor has a relic affixed to it.

My only wish is that the relic's stat information would show in the armor's tooltip. Additionally, if there isn't already a way to do so, it would be nice to have a way to "un-affix" a relic from armor so that the relic could be re-used. I'm imagining a scenario where I have iron armor and found a good relic I want to use. Once I upgrade to diamond or netherite, I'd still like to have the relic bonuses.