BareMinimumStudios / playerex

Adds RPG attributes to Minecraft using the Fabric ecosystem.
MIT License
2 stars 10 forks source link

Item breaking mechanics #29

Closed naomieow closed 3 months ago

bibi-reden commented 3 months ago

It was suggested to add a config option to disable/enable breaking, so it was incorporated, otherwise, this PR is good to go

bibi-reden commented 3 months ago

If you want, though this is a suggestion, you can have it where it removes the "broken" items whenever item breaking is disabled.

You can subscribe to it with a @Hook annotation on itemBreakingEnabled in the config model, build the project, subscribe to the generated function, and check on world init if it is enabled or not. This is just a suggestion and the state of the system as is works fine with or without this addition.

bibi-reden commented 3 months ago

Feel free to squash & merge when ready