search

BarelyFunctionalCode / animation-transmog

This is a simple plugin which allows the player to customize which animations are used for various actions.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Teleport transmogs are not long enough #12

Closed Khufuhk closed 1 year ago

Khufuhk commented 1 year ago

Animations for teleport transmogs end before the teleport happens leaving the player in regular standing position for one tick. Would it be possible to delay the beginning to make the animation seamless?

BarelyFunctionalCode commented 1 year ago

Yeah I've tried addressing this a couple times. It's a bit tricky since there are multiple ways to teleport and each method has different lengths of animations that I'm overriding.

Which teleporting method are you seeing this in? A teletab? A teleport spell? Jewelry?

I'll see if I can refine the way it overrides the normal animations and stretch the custom animations to the amount of frames of the original animation.

Khufuhk commented 1 year ago

I noticed with the default spellbook teleports and the amulet of glory, so the purple sphere animation. I actually don't think I tested with it with tabs.

BarelyFunctionalCode commented 1 year ago

Okay cool I'll take a look and see if I can refine it a bit better.

Thanks for pointing it out!

I'll let you know on this issue if/when I'm able to fix it.

BarelyFunctionalCode commented 1 year ago

This issue will be resolved with commit dbf9507c3d3e82a663cdb57a2ba60f6b13abcb6a

BarelyFunctionalCode commented 1 year ago

Issue will be closed with PR https://github.com/runelite/plugin-hub/pull/4244

BarelyFunctionalCode commented 1 year ago

This issue should be resolved now. Let me know if you have any more problems.

Thanks, Nick