search

BarelyFunctionalCode / animation-transmog

This is a simple plugin which allows the player to customize which animations are used for various actions.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Plank death animation only lasting 1 tic #13

Closed SoloDarkness closed 1 year ago

SoloDarkness commented 1 year ago

My charcter lands on the ground and instantly stands back up with the red bar long before i go to my respawn point. I have seen this plugin working fine on pk streams but cant seem to get it to work for me. Might be user error..?

BarelyFunctionalCode commented 1 year ago

I don't think this is a user error because I've seen this issue inconsistently.

It's a bit hard overriding the death animation because the default animations doesn't have a set length and I think it just resets when you respawn.

I can look into fixing this issue.

SoloDarkness commented 1 year ago

thank you! very quick response!

BarelyFunctionalCode commented 1 year ago

Yup no problem. I'm gonna try to look at this and a couple more issues in a couple days.

I'll update this issue with what I find.

BarelyFunctionalCode commented 1 year ago

So I've finally been able to get my dev environment set back up to work on this plugin. I was testing out the death plank animation and I can't seem to recreate the issue you're having.

What I see is that when the character dies, it does the plank animation for a while, then for like the last tick before respawning it will stand back up (I'm going to see if I can fix this as well). But from what you're explaining it seems like it's immediately standing back up for you.

Do you think you could provide small video clip or gif of this happening? And also maybe a screenshot of the other Runelite plugins you have installed. That way I should be able to see what exactly is going on and maybe hopefully recreate the issue.

Thanks! Nick

BarelyFunctionalCode commented 1 year ago

I figured out what the issue most likely is. The timer I use to count the frames of an animation to know when to end the custom animation doesn't take into account your client FPS.

So I'm assuming your death animation ends so quickly because you probably have uncapped FPS turned on and its really really high haha.

So I'll modify the timer I use to account for FPS (rookie mistake) and that should fix the issue.

BarelyFunctionalCode commented 1 year ago

I'll try and get this update pushed to the Runelite Plugin Hub in the next day or so. I'll update here when it's done.

SoloDarkness commented 1 year ago

thank you so much <3 amazing service!! great work

BarelyFunctionalCode commented 1 year ago

Issue will be closed with PR https://github.com/runelite/plugin-hub/pull/4244

BarelyFunctionalCode commented 1 year ago

This should be fixed now. Let me know if you have any issues.

Thanks again for bringing this up, it turned out to be the biggest bug in the plugin causing a lot of other issues. The plugin should be running a lot better now.

Nick