search

Barina / Dark-Telegram

Dark mode implementation for Telegram Web based on Dark-WhatsApp by vednoc with many improvements and wide range of customization options.
MIT License
16 stars 5 forks source link

Radio buttons and toggles look odd in "off" state #16

Open prakharb5 opened 3 years ago

prakharb5 commented 3 years ago

Screenshot 2020-12-23 at 21 32 27

The black does not suit. Make it grey?

Barina commented 3 years ago

You control the color in the config. "Base control color" I think..

prakharb5 commented 3 years ago

I did not like this approach, TBH. Should it not be given as separate option?

Barina commented 3 years ago

Well it's a control, all controls should have the same style to be consistent. otherwise it'll be a big mess :) Why does the radio button should have a separate option?

The issue here with the radio button IMO is that its line is thicker then the outline of the toggle button above it. which does looks inconsistent.

BTW you can always fork this project and make personal changes and also pull requests :)

prakharb5 commented 3 years ago

The thing is, the base control color also controls the color of the chat UI and the bg color of the contacts on left. Controlling that with color of radio buttons is.... Odd.

Why not pair it with accent color?

Regarding the forking, I do not know CSS 😅.

Barina commented 3 years ago

You didn't like this approach for a reason, the radio button uses border color for the inner line which should be a "lower" or "higher" base control color. The thing is, this style is based on the WhatsApp dark style so I tried to make everything similar as mush as I can and I didn't knew about Stylus lang at all before looking in the WhatsApp style.. this is why this style is ~75% CSS rather than Stylus unfortunately.

I agree with you that a change is welcomed here to at least be able to differentiate between UI elements. This may lead to fundamental overhaul but still easy to implement (I think 😅)